Opened 5 years ago

Closed 4 years ago

#1297 closed change (fixed)

Prefix internal events with "_"

Reported by: fhd Assignee: Mailkov
Priority: P4 Milestone:
Module: Libadblockplus Keywords:
Cc: trev Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

https://github.com/adblockplus/libadblockplus/pull/3

Description

Background

FilterEngine currently throws two events that are only used internally: "init" and "updateCheckDone". Since there can be only one callback for each event, we should make it more obvious that clients shouldn't interfere with those events. Prefixing by "_" seems like it would make this more obvious.

What to change

Prefix the "init" and "updateCheckDone" events with a "_".

Change History (7)

comment:1 Changed 5 years ago by trev

  • Cc trev added

comment:2 Changed 5 years ago by Mailkov

Hi, I would like to work on this !!!

comment:4 Changed 5 years ago by Mailkov

Can you assign it to me? So I will receive e-mail on this issue.

comment:5 Changed 5 years ago by fhd

  • Owner set to Mailkov

comment:6 Changed 5 years ago by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed 4 years ago by fhd

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.