Opened 5 years ago

Last modified 2 years ago

#1298 new change

AppInfo should be passed into FilterEngine, not JsEngine

Reported by: fhd Assignee:
Priority: P4 Milestone:
Module: Libadblockplus Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

Description (last modified by fhd)

Background

We're currently passing the AppInfo object to JsEngine, which does nothing but make it available as a global object. Since the object is highly Adblock Plus specific, we should pass it to FilterEngine instead.

What to change

Pass the AppInfo object to FilterEngine instead of JsEngine.

While we're at it - it probably shouldn't be optional.

Change History (2)

comment:1 Changed 5 years ago by fhd

  • Description modified (diff)

comment:2 Changed 2 years ago by fhd

  • Cc trev removed
Note: See TracTickets for help on using tickets.