Opened 5 years ago

Closed 2 years ago

#1301 closed change (rejected)

Don't fake window.content property in the Blockable items frame

Reported by: trev Assignee:
Priority: P4 Milestone:
Module: Adblock-Plus-for-Firefox Keywords: goodfirstbug
Cc: Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

Description

Background

The list of blockable items runs inside a frame in the browser window. For historical reasons, we define a window.content property inside this frame that points to the window object of the current browser tab - this frame started out as a sidebar, and Firefox sidebars have that functionality. This is somewhat ugly though https://bugzilla.mozilla.org/show_bug.cgi?id=930787#c15 is the first issue this approach ever caused.

What to change

Implement this functionality in a more obvious way, e.g. as a getCurrentContentWindow() function - this way it is obviously a dynamically determined value rather than a constant.

Change History (2)

comment:1 Changed 5 years ago by philll

  • Platform changed from Firefox/Firefox Mobile to Firefox

Made Firefox and Firefox mobile available as seperate platforms.

comment:2 Changed 2 years ago by trev

  • Resolution set to rejected
  • Status changed from new to closed

Mass-closing all bugs in Adblock Plus for Firefox module, the codebase of Adblock Plus 3.0 belongs into Platform and User-Interface modules. Old bugs are unlikely to still apply.

Note: See TracTickets for help on using tickets.