Opened 5 years ago

Closed 14 months ago

#1319 closed change (fixed)

Move application update checks to a dedicated Updater component

Reported by: fhd Assignee:
Priority: P3 Milestone:
Module: Libadblockplus Keywords:
Cc: simona Blocked By: #1285
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Background

FilterEngine is currently performing application update checks in the background. After #1285 this should be disabled by default - but it still doesn't belong into FilterEngine in the first place.

What to change

We should have a separate Updater class and move the updating logic from FilterEngine to it, as well as any API related to application update checks.

This will be a bit tricky, since application update checks are implemented in the Adblock Plus core code, interacting with it will probably have to move to a component shared by FilterEngine and Updater. See #1285 for some discussion on this.

Change History (4)

comment:1 Changed 5 years ago by fhd

  • Blocked By 1285 added

comment:2 Changed 5 years ago by simona

  • Blocking 542 added
  • Cc simona added
  • Keywords large-scale-deployments growth added

comment:3 Changed 5 years ago by fhd

  • Blocking 542 removed
  • Keywords large-scale-deployments growth removed

This is just a refactoring, it's not required disabling updates at all. #1285 will fully take care of that.

comment:4 Changed 14 months ago by sergz

  • Resolution set to fixed
  • Status changed from new to closed
  • Tester set to Unknown
Note: See TracTickets for help on using tickets.