Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#1355 closed change (fixed)

avoid adblockplus.org to change its URL to platform-specific path

Reported by: philll Assignee: trev
Priority: P2 Milestone:
Module: Infrastructure Keywords:
Cc: till, trev Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5455756203655168

Description

Background

Journalists and other people linking to adblockplus.org very often don't recognize the platform-specific redirect and thus link to the URL matching their browser platform instead of the generic URL. Users opening this link with another browser are then confused about the grey download link. To avoid this to happen without breaking the possibility of specifically linking to a platform-specific version of the website, we want to have internal redirects instead of redirecting the user himself.

What to change

Avoid adblockplus.org to change its URL to a platform-specific path in the user's browser, while keeping the possibility of specifically linking to a platform-specific version of the website.

Change History (7)

comment:1 Changed 5 years ago by trev

  • Owner set to trev

comment:2 Changed 5 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

I decided to push this change already because the approach has been discussed and Felix is currently on vacation. This still needs to be reviewed however.

comment:3 Changed 5 years ago by trev

There is also an effect that might not be desirable: https://adblockplus.org/bg won't redirect either. This means however that browser switching links point to https://adblockplus.org/chrome for example and ignore the selected language (Bulgarian in this case).

Version 0, edited 5 years ago by trev (next)

comment:4 Changed 5 years ago by trev

Alternatively, we can always redirect ​https://adblockplus.org/bg to ​https://adblockplus.org/bg/.

Implemented this, not having ambiguous URLs here seems to be a good idea anyway.

comment:5 Changed 5 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Got LGTM in the review. The changes themselves have been applied a while ago.

comment:6 Changed 5 years ago by till

This fix doesn't solve the problem for existing links (e.g. here: http://www.huffingtonpost.com/2014/08/15/pop-up-ads-sorry-ethan-zuckerman_n_5681439.html).

comment:7 Changed 5 years ago by trev

Yes, as discussed. We cannot do this without breaking the platform switching mechanism.

Note: See TracTickets for help on using tickets.