Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#1357 closed change (fixed)

Remove the DEBUB_BLOCKER and other DEBUG macroses

Reported by: oleksandr Assignee: Mailkov
Priority: P3 Milestone: Adblock-Plus-for-Internet-Explorer-1.5
Module: Adblock-Plus-for-Internet-Explorer Keywords: goodfirstbug
Cc: oleksandr Blocked By:
Blocking: Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5747779603267584

Description

Background

Currently we have a lot of DEBUB_BLOCKER, DEBUG_HIDE etc macroses throughout the code. They are mostly broken, and don't act as they should.

What to change

Change all the instances of DEBUB_BLOCKER, DEBUG_PARSER, DEBUG_HIDE etc to respective counter part from CPluginDebug

Change History (11)

comment:1 Changed 4 years ago by Mailkov

I would like to work on this change.

comment:2 Changed 4 years ago by oleksandr

  • Owner set to Mailkov

Here you go!

comment:3 Changed 4 years ago by oleksandr

Did we miss a pull request here? What's the status here?

comment:4 Changed 4 years ago by Mailkov

Hi,
This week I have not been good, so I could not, as my intention to devote to this issue.

However, looking at it now, I do not find instances of DEBUG_BLOCKER ...

Can You show me code of an instance of DEBUG_BLOCKER ? ... So I can quickly close this issue.

comment:5 Changed 4 years ago by Mailkov

On file Config.h

there are this line:

#define DEBUG_FUNC CPluginDebug::Debug
#define DEBUG_ERROR_FUNC CPluginDebug::DebugError
#define DEBUG_ERROR_CODE_FUNC CPluginDebug::DebugErrorCode

#if (defined ENABLE_DEBUG_INFO && defined ENABLE_DEBUG_GENERAL)
#undef  DEBUG_GENERAL
#define DEBUG_GENERAL(x) DEBUG_FUNC(x);
#endif

#if (defined ENABLE_DEBUG_INFO)
#undef  DEBUG
#define DEBUG(x) DEBUG_FUNC(x);
#endif

#if (defined ENABLE_DEBUG_INFO && defined ENABLE_DEBUG_BLOCKER)
#undef  DEBUG_BLOCKER
#define DEBUG_BLOCKER(x) DEBUG_FUNC(x);
#endif

#if (defined ENABLE_DEBUG_INFO && defined ENABLE_DEBUG_FILTER)
#undef  DEBUG_FILTER
#define DEBUG_FILTER(x) DEBUG_FUNC(x);
#endif

The DEBUG_BLOCKER(x) is defined as DEBUG_FUNC(x) and DEBUG_FUNC is defined as CPluginDebug::Debug

So DEBUG_BLOCKER is already a CPluginDebug macrose , so I don't know what to do, can You help me ?

Thanks

comment:6 Changed 4 years ago by oleksandr

We would like to move away from these macros. So wherever there is a DEBUG_BLOCKER there should be CPluginDebug::Debug directly instead. All the unused macros would be deleted then.

comment:8 Changed 4 years ago by oleksandr

See the discussion about this issue here: http://codereview.adblockplus.org/5747779603267584/#msg6

comment:9 Changed 4 years ago by Mailkov

I read the discussion, I think I have done what You had asked for this issue ...
I'm not really cranky ... :) because I love to program, so there is no problem if you want reject my pull request.
Tell me what you want me to do. I'll do it.

comment:10 Changed 4 years ago by oleksandr

  • Resolution set to fixed
  • Review URL(s) modified (diff)
  • Status changed from new to closed

The pull request has been rejected. Please let us know if you'd like to work on some non 'goodfirstbug' issue though ;)

comment:11 Changed 4 years ago by oleksandr

  • Milestone set to Adblock-Plus-for-Internet-Explorer-1.5
Note: See TracTickets for help on using tickets.