Opened on 09/11/2014 at 11:46:03 AM

Closed on 03/13/2015 at 07:56:56 AM

Last modified on 03/13/2015 at 07:58:10 AM

#1357 closed change (fixed)

Remove the DEBUB_BLOCKER and other DEBUG macroses

Reported by: oleksandr Assignee: Mailkov
Priority: P3 Milestone: Adblock-Plus-for-Internet-Explorer-1.5
Module: Adblock-Plus-for-Internet-Explorer Keywords: goodfirstbug
Cc: oleksandr Blocked By:
Blocking: Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):



Currently we have a lot of DEBUB_BLOCKER, DEBUG_HIDE etc macroses throughout the code. They are mostly broken, and don't act as they should.

What to change

Change all the instances of DEBUB_BLOCKER, DEBUG_PARSER, DEBUG_HIDE etc to respective counter part from CPluginDebug

Attachments (0)

Change History (11)

comment:1 Changed on 01/08/2015 at 09:47:10 PM by Mailkov

I would like to work on this change.

comment:2 Changed on 01/08/2015 at 11:07:27 PM by oleksandr

  • Owner set to Mailkov

Here you go!

comment:3 Changed on 02/13/2015 at 02:48:00 AM by oleksandr

Did we miss a pull request here? What's the status here?

comment:4 Changed on 02/13/2015 at 07:45:51 AM by Mailkov

This week I have not been good, so I could not, as my intention to devote to this issue.

However, looking at it now, I do not find instances of DEBUG_BLOCKER ...

Can You show me code of an instance of DEBUG_BLOCKER ? ... So I can quickly close this issue.

comment:5 Changed on 02/16/2015 at 07:58:57 AM by Mailkov

On file Config.h

there are this line:

#define DEBUG_FUNC CPluginDebug::Debug
#define DEBUG_ERROR_FUNC CPluginDebug::DebugError
#define DEBUG_ERROR_CODE_FUNC CPluginDebug::DebugErrorCode


#if (defined ENABLE_DEBUG_INFO)
#undef  DEBUG
#define DEBUG(x) DEBUG_FUNC(x);



The DEBUG_BLOCKER(x) is defined as DEBUG_FUNC(x) and DEBUG_FUNC is defined as CPluginDebug::Debug

So DEBUG_BLOCKER is already a CPluginDebug macrose , so I don't know what to do, can You help me ?


comment:6 Changed on 02/19/2015 at 08:44:18 AM by oleksandr

We would like to move away from these macros. So wherever there is a DEBUG_BLOCKER there should be CPluginDebug::Debug directly instead. All the unused macros would be deleted then.

comment:7 Changed on 02/25/2015 at 02:13:41 PM by Mailkov

comment:8 Changed on 03/04/2015 at 09:24:30 PM by oleksandr

See the discussion about this issue here:

comment:9 Changed on 03/05/2015 at 04:04:05 PM by Mailkov

I read the discussion, I think I have done what You had asked for this issue ...
I'm not really cranky ... :) because I love to program, so there is no problem if you want reject my pull request.
Tell me what you want me to do. I'll do it.

comment:10 Changed on 03/13/2015 at 07:56:56 AM by oleksandr

  • Resolution set to fixed
  • Review URL(s) modified (diff)
  • Status changed from new to closed

The pull request has been rejected. Please let us know if you'd like to work on some non 'goodfirstbug' issue though ;)

comment:11 Changed on 03/13/2015 at 07:58:10 AM by oleksandr

  • Milestone set to Adblock-Plus-for-Internet-Explorer-1.5

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Mailkov.
Note: See TracTickets for help on using tickets.