Opened 5 years ago
Closed 5 years ago
#1362 closed change (fixed)
createNightlies script should call ensure_dependencies
Reported by: | trev | Assignee: | trev |
---|---|---|---|
Priority: | P4 | Milestone: | |
Module: | Infrastructure | Keywords: | |
Cc: | Blocked By: | #170, #1361 | |
Blocking: | Platform: | Unknown | |
Ready: | yes | Confidential: | no |
Tester: | Verified working: | no | |
Review URL(s): |
Description
Background
See #170, we've implemented our custom dependencies mechanism and the development build creation needs to expect that the extensions actually use it.
What to change
When createNightlies.py clones the extension directory, it should run ensure_dependencies on it. Since it uses its own buildtools copy it should disable self-update and make sure buildtools dependency isn't being pulled. It also needs to override roots setting.
Change History (3)
comment:1 Changed 5 years ago by trev
- Blocked By 1361 added
comment:2 Changed 5 years ago by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed 5 years ago by trev
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
Fixed: https://hg.adblockplus.org/sitescripts/rev/76cae46d043b