Opened 6 years ago

Last modified 5 years ago

#1377 closed defect

Blacklist resources managed by ensure_dependencies.py in Git — at Version 5

Reported by: matze Assignee: poz2k4444
Priority: P4 Milestone:
Module: Automation Keywords: infrastructure hg git
Cc: trev, fhd, poz2k4444, AAlvz Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5934936779390976
https://github.com/mjhennig/adblockplus-infrastructure/pull/7

Description

Observed Behavior

When working with the new ensure_dependencies.py script and git(1), one currently needs to manually ensure that the contents of fetched modules are not added to the git index.

Possible Workarounds

Below please find a list of possible workarounds beside manually maintaining the module paths in a .gitignore file - without necessity of completeness but in order of recommendation:

  • Use git-update-index(1) in to blacklist the resource paths from being added to the index.
  • Manually maintain the destination paths in the .git/info/exclude file.
  • Create some fancy githooks(5) to circumvent the issue.

Expected Behavior

The ensure_dependencies.py script should *automagically* apply one of the aforementioned workarounds (except the .gitignore file solution, of course).

Change History (5)

comment:3 Changed 6 years ago by trev

  • Component changed from Unknown to Build-and-Release-Tools
  • Priority changed from Unknown to P4
  • Ready set

You shouldn't modify the copy in the infrastructure repository but rather the master in the buildtools repository.

comment:4 Changed 6 years ago by matze

  • Owner set to poz2k4444

We will, the Git version is only used for collaboration and testing right now. The patch-set for review will address the buildtools version, however.

comment:5 Changed 6 years ago by matze

  • Review URL(s) modified (diff)
Note: See TracTickets for help on using tickets.