Changes between Version 2 and Version 4 of Ticket #1378


Ignore:
Timestamp:
05/29/2015 10:36:26 PM (5 years ago)
Author:
fhd
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #1378 – Description

    v2 v4  
    33 
    44=== What to change === 
    5 Pass event callbacks by reference in `JsEngine::SetEventCallback` and `FilterEngine::SetFilterChangeCallback`. Event callbacks are currently being stored by value in an `std::map` in `JsEngine` - we'll have to store a pointer instead. 
     5Pass event callbacks by reference in `JsEngine::SetEventCallback`, `FilterEngine::SetFilterChangeCallback` and `FilterEngine::SetUpdateAvailableCallback`. Event callbacks are currently being stored by value in an `std::map` in `JsEngine` - we'll have to store a pointer instead. 
    66 
    77Once this is done, we should check client and test code that works with event callbacks - we will be able to get rid of some hacks there.