Opened on 09/17/2014 at 02:56:11 PM

Closed on 07/03/2018 at 09:27:29 AM

#1382 closed change (invalid)

[sitescripts] Use the correct buildtools revision when creating nightlies

Reported by: fhd Assignee:
Priority: P3 Milestone:
Module: Sitescripts Keywords:
Cc: greiner, sebastian, tlucas Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by fhd)

Background is currently calling directly into buildtools (referenced as a submodule) to create nightly builds.

The problem with this is that this will always use the revision of buildtools linked in sitescripts - not the one linked in the respective project (e.g. adblockpluschrome).

What to change

There are multiple ways to achieve this, but I think the cleanest one is to stop calling into buildtools directly, and to call a script (e.g. the project's instead - moving the release build logic from to that one.

Attachments (0)

Change History (7)

comment:1 Changed on 09/17/2014 at 02:56:52 PM by fhd

Please set it to ready if you agree Wladimir. Also feel free to adjust the priority: I felt this should at least be P3 since it causes problems in practice.

comment:2 Changed on 09/17/2014 at 03:50:23 PM by fhd

  • Description modified (diff)

comment:3 Changed on 09/17/2014 at 04:00:38 PM by trev

  • Ready set

I was under the impression that we use hg archive instead of cloning repositories for development build generation - but apparently we do the latter in order to get the dependencies. That means that we can call instead of packager.createBuild(), there will be no performance difference. We can also replace the build.generateDocs() call the same way.

This will still cause some inconsistencies, we cannot really avoid using a different buildtools copy to get the metadata - but I guess that's better than the current state.

comment:4 Changed on 02/19/2015 at 01:40:49 PM by sebastian

  • Component changed from Infrastructure to Sitescripts

comment:5 Changed on 12/21/2017 at 11:29:28 AM by fhd

  • Cc trev removed

comment:6 Changed on 03/06/2018 at 02:24:32 PM by kvas

  • Cc sebastian tlucas added
  • Tester set to Unknown

@sebastian, @tlucas: Is this ticket still relevant? If so, should it be moved to Automation module or is it actually Sitescripts?

comment:7 Changed on 07/03/2018 at 09:27:29 AM by tlucas

  • Resolution set to invalid
  • Status changed from new to closed

Closing this ticket, since abpssembly is currently calling the target repository directly.

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Note: See TracTickets for help on using tickets.