Opened 6 years ago

Closed 5 years ago

Last modified 4 years ago

#139 closed change (fixed)

[Remove timeline code] Remove timeline.js and callers

Reported by: trev Assignee: beelzy
Priority: P4 Milestone: Adblock-Plus-2.6.5-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords: goodfirstbug
Cc: Blocked By:
Blocking: #138 Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

Description

Background

See #138.

What to change

lib/timeline.js and everything using it can be removed.

Attachments (1)

remove_timeline.patch (21.8 KB) - added by beelzy 5 years ago.
Apply to commit 972408582c2390594f1bda74b1d8fdde2f4e215b (should be the latest one at time of writing)

Download all attachments as: .zip

Change History (10)

comment:1 Changed 5 years ago by trev

  • Keywords goodfirstbug added
  • Ready unset

comment:2 Changed 5 years ago by philll

You marked this as goodfirstbug but at the same time removed the ready flag. Shall this be worked on or not?

comment:3 Changed 5 years ago by trev

  • Ready set

Sure, it can be worked on - that issue was simply filed before the ready flag was added, so any (unrelated) change would "unset" it.

comment:4 Changed 5 years ago by beelzy

Hi, can I work on this bug? I've already removed the lines that use Timeline and got rid of timeline.js. Tests work fine except for certain unit tests that weren't already working (I saw there was an issue for that). Just need to create a patch for it.

comment:5 Changed 5 years ago by trev

  • Owner set to beelzy

I assigned that issue to you. Please see https://adblockplus.org/en/contribute-code for some general instructions. Once you are done you can create a GitHub pull request or attach the patch here.

Changed 5 years ago by beelzy

Apply to commit 972408582c2390594f1bda74b1d8fdde2f4e215b (should be the latest one at time of writing)

comment:6 Changed 5 years ago by beelzy

Attached the patch. Where do I send the contributor agreement to? I could possibly also do #140 as well, since it appears to be closely related.

Last edited 5 years ago by beelzy (previous) (diff)

comment:7 Changed 5 years ago by trev

Sorry about the late reply, I somehow forgot replying here. The contributor agreement should go to me (trev@…).

comment:8 Changed 5 years ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Platform set to Firefox/Firefox Mobile
  • Resolution set to fixed
  • Status changed from new to closed

Heh, this one dropped off my radar again :-(

Anyway, fixed:
https://hg.adblockplus.org/adblockplus/rev/47be8c5680f7
https://hg.adblockplus.org/adblockplus/rev/7313f49c65e3

The original patch has been rebased. The second patch actually makes sure that the removed timelineID parameter isn't being passed in by the caller.

comment:9 Changed 4 years ago by philll

  • Platform changed from Firefox/Firefox Mobile to Firefox

Made Firefox and Firefox mobile available as seperate platforms.

Note: See TracTickets for help on using tickets.