Opened 3 years ago

Closed 2 months ago

#1397 closed defect (fixed)

FilterEngine::ForceUpdateCheck crashes when passed a 0 std::function

Reported by: fhd Assignee: sergz
Priority: P2 Milestone:
Module: Libadblockplus Keywords:
Cc: asmirnov Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29389580/

Description (last modified by fhd)

Environment

libadblockplus revision f6d33ae55666.

How to reproduce

With a working FilterEngine instance, simply call:

filterEngine->ForceUpdateCheck();

Observed behaviour

The JS code in lib/updater.js tries to invoke the native callback, causing a crash.

Expected behaviour

The update check should finish normally.

As a workaround, create a no-op function and pass that one. (While fixing this, we should remove these workarounds from the test code.)

Change History (7)

comment:1 Changed 3 years ago by fhd

  • Description modified (diff)

comment:2 Changed 3 years ago by fhd

  • Description modified (diff)

comment:3 Changed 3 years ago by fhd

  • Component changed from Unknown to Libadblockplus
  • Priority changed from Unknown to P3
  • Ready set

comment:4 Changed 2 months ago by sergz

  • Cc asmirnov added
  • Owner set to sergz
  • Priority changed from P3 to P2
  • Tester set to Unknown

There was a duplicate #5016.

comment:5 Changed 2 months ago by sergz

  • Review URL(s) modified (diff)

comment:7 Changed 2 months ago by sergz

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.