Opened on 09/18/2014 at 02:47:51 PM

Closed on 03/21/2017 at 02:39:10 PM

#1397 closed defect (fixed)

FilterEngine::ForceUpdateCheck crashes when passed a 0 std::function

Reported by: fhd Assignee: sergz
Priority: P2 Milestone:
Module: Libadblockplus Keywords:
Cc: asmirnov Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by fhd)


libadblockplus revision f6d33ae55666.

How to reproduce

With a working FilterEngine instance, simply call:


Observed behaviour

The JS code in lib/updater.js tries to invoke the native callback, causing a crash.

Expected behaviour

The update check should finish normally.

As a workaround, create a no-op function and pass that one. (While fixing this, we should remove these workarounds from the test code.)

Attachments (0)

Change History (7)

comment:1 Changed on 09/18/2014 at 02:48:29 PM by fhd

  • Description modified (diff)

comment:2 Changed on 09/18/2014 at 02:50:07 PM by fhd

  • Description modified (diff)

comment:3 Changed on 09/18/2014 at 02:50:31 PM by fhd

  • Component changed from Unknown to Libadblockplus
  • Priority changed from Unknown to P3
  • Ready set

comment:4 Changed on 03/20/2017 at 09:35:06 AM by sergz

  • Cc asmirnov added
  • Owner set to sergz
  • Priority changed from P3 to P2
  • Tester set to Unknown

There was a duplicate #5016.

comment:5 Changed on 03/20/2017 at 02:16:08 PM by sergz

  • Review URL(s) modified (diff)

comment:6 Changed on 03/21/2017 at 02:17:17 PM by abpbot

comment:7 Changed on 03/21/2017 at 02:39:10 PM by sergz

  • Resolution set to fixed
  • Status changed from new to closed

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sergz.
Note: See TracTickets for help on using tickets.