Opened 5 years ago

Last modified 3 years ago

#14 reopened change

Fix periodic subscription refresh or remove it from advanced settings

Reported by: fhd Assignee:
Priority: P3 Milestone:
Module: Adblock-Plus-for-Android Keywords:
Cc: rjeschke, sergz Blocked By:
Blocking: Platform: Android
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by rjeschke)

Background

See #7.

What to change

Fix periodic subscription refresh or remove it from advanced settings.

This is about the fact that nothing you set in advanced options for subscription refresh has any effect on the refresh process (as everything is only controlled by libadblockplus/adblockplus).

Change History (19)

comment:1 Changed 5 years ago by philll

  • Blocking 7 added

comment:2 Changed 5 years ago by philll

  • Keywords libadblockplus integration cleanup removed

comment:3 Changed 5 years ago by trev

  • Component changed from Unknown to ABP-Android

comment:4 Changed 5 years ago by philll

  • Owner set to rjeschke
  • Status changed from new to assigned

comment:5 Changed 5 years ago by fhd

  • Description modified (diff)
  • Summary changed from [libadblockplus integration cleanup] Reimplement periodic subscription refresh or remove its configuration from advanced settings. to [libadblockplus integration cleanup] Fix periodic subscription refresh or remove it from advanced settings

comment:6 Changed 5 years ago by fhd

  • Reporter changed from philll to fhd

comment:7 Changed 5 years ago by fhd

  • Priority changed from Unknown to P3

comment:8 Changed 5 years ago by fhd

  • Owner rjeschke deleted

comment:9 Changed 5 years ago by fhd

  • Status changed from assigned to accepted

comment:10 Changed 5 years ago by philll

  • Status changed from accepted to new

comment:11 Changed 5 years ago by rjeschke

  • Blocking 7 removed
  • Ready unset
  • Summary changed from [libadblockplus integration cleanup] Fix periodic subscription refresh or remove it from advanced settings to Fix periodic subscription refresh or remove it from advanced settings

comment:12 Changed 5 years ago by fhd

René, can you add some more info here if you know what this is about? Also, no need to mention #7 in the description anymore now that the connection is gone.

comment:13 Changed 5 years ago by philll

  • Cc rjeschke added

@rjeschke:

comment:14 Changed 4 years ago by rjeschke

  • Platform set to Android
  • Ready set

comment:15 Changed 4 years ago by rjeschke

  • Description modified (diff)

comment:16 Changed 4 years ago by agnieszka.domanska

I'll take that. If I may make a decision I will just remove it. If you would prefer me to try to fix it first - what should be the meaning of "periodically" (how often should it refresh)?

comment:17 Changed 4 years ago by agnieszka.domanska

I removed periodic subscription refresh from Advance Preferences. Pull request on github.

comment:18 Changed 3 years ago by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:19 Changed 3 years ago by sergz

  • Cc sergz added
  • Review URL(s) modified (diff)
  • Status changed from reviewing to reopened
  • Tester set to Unknown

The PR is closed, so I have removed it from Review URL field and changed the state of the issue.

If we want to have the ability to configure the update interval we need to firstly make changes in adblockpluscore, see #3677.

Note: See TracTickets for help on using tickets.