Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#1423 closed change (fixed)

Fix bogus JNI compile errors

Reported by: fhd Assignee:
Priority: P3 Milestone: Adblock-Plus-for-Android-1.3
Module: Adblock-Plus-for-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Android
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5144051300958208/

Description

Environment

Adblock Plus for Android revision c762ea965d6c in Eclipse Kepler SR2 with ADT 23.0.0.1245622.

How to reproduce

  1. Import adblockplusandroid in Eclipse as described in the README.
  2. Open any cpp file in jni and make a change.

Observed behaviour

Compile errors and warnings about things like jobject show up.

Expected behaviour

There shouldn't be any errors - it does compile just fine with ndk-build.

Change History (3)

comment:1 Changed 5 years ago by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 5 years ago by fhd

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:3 Changed 5 years ago by fhd

  • Milestone set to Adblock-Plus-for-Android-1.3
Note: See TracTickets for help on using tickets.