Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#1424 closed change (fixed)

Update libadblockplus-binaries dependency in the adblockplusandroid repository to revision 6f79af14ad4e

Reported by: fhd Assignee:
Priority: P2 Milestone: Adblock-Plus-for-Android-1.3
Module: Adblock-Plus-for-Android Keywords:
Cc: Blocked By:
Blocking: #98, #985 Platform: Android
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6245218638626816/

Description (last modified by fhd)

Background

The libadblockplus-binaries dependency is currently at 7b68c61243c5, which is libadblockplus revision 1ae1b8d23f10.

The following issues have been resolved since then:

What to change

The libadblockplus-binaries dependency should be updated to 6f79af14ad4e, which is libadblockplus revision 46f045921142.

Hints for testers

The only change that should be able to cause regressions is #1286. This affects filter matching, so be sure to test that adblocking works for various resource types.

Change History (11)

comment:1 Changed 5 years ago by fhd

  • Description modified (diff)

comment:2 Changed 5 years ago by fhd

  • Description modified (diff)

comment:3 Changed 5 years ago by fhd

  • Description modified (diff)

comment:4 Changed 5 years ago by fhd

  • Blocking 985 added

comment:5 Changed 5 years ago by fhd

  • Blocking 985 removed
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed 5 years ago by fhd

  • Blocking 985 added

comment:7 Changed 5 years ago by philll

I guess, #1296 should be closed (and thus pushed) before this here is going to land?!

comment:8 Changed 5 years ago by fhd

Yes. As I said in the review, the libadblockplus and libadblockplus-binaries revisions referred to are not pushed yet. Not brilliant, but I really wanted to move on to make sure Android updates work again ASAP.

comment:9 Changed 5 years ago by fhd

  • Description modified (diff)
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:11 Changed 5 years ago by fhd

  • Milestone set to Adblock-Plus-for-Android-1.3
Note: See TracTickets for help on using tickets.