Opened 6 years ago

Last modified 5 years ago

#1431 closed defect

Block element preview does not accurately demonstrate the effects of the suggested filter — at Version 2

Reported by: passbrains Assignee:
Priority: Unknown Milestone:
Module: Platform Keywords:
Cc: sebastian, trev, sven Blocked By:
Blocking: Platform: Unknown
Ready: no Confidential: no
Tester: Verified working: no
Review URL(s):

Description (last modified by greiner)

Adapted from https://www.passbrains.com/dashboard/view-ticket.php?ticket_no=AOP-67

Environment

Windows + Vista 64bit + Opera + English
ABP version Adblock Plus Version 1.8.5.1221

How to reproduce

  1. Install ABP extension on Opera.
  1. Loads website  http://www.search.com/prefs
  2. Click on ABP and select Block element.
  3. Try to block a particular checkbox

Filter used is  www.search.com##.engine.checkbox
see image 1 and image 2

  1. Reload the page.  See image 3

Observed behaviour

After step 4, it shows blocking of 1 checkbox as shown in image 2.
After step 5, it shows blocking of all checkbox. see image 3

Expected behaviour

Step 4 and step 5 shall results in blocking same number of checkbox.

Change History (5)

Changed 6 years ago by passbrains

Changed 6 years ago by passbrains

Changed 6 years ago by passbrains

comment:1 Changed 6 years ago by passbrains

1 - 23 Sep 2014 14:09:41 posted by Thomas Greiner
The filter is working as intended but the preview sets wrong expectations since it only checks whether the filter applies to the selected element.

comment:2 Changed 6 years ago by greiner

  • Description modified (diff)

There are also inconsistencies between previewed and actual behavior when the "Hide placeholders" option is disabled (see #AOP-88). For this particular case we could either implement special handling or ignore it.

Note: See TracTickets for help on using tickets.