Changes between Version 12 and Version 14 of Ticket #1434


Ignore:
Timestamp:
12/16/2015 10:49:03 AM (4 years ago)
Author:
sebastian
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #1434

    • Property Tester changed from to Unknown
    • Property Blocked By changed from to 3418
    • Property Summary changed from Remove non-standard JS usage from buildtools to Remove remaining non-standard JS usage from buildtools
  • Ticket #1434 – Description

    v12 v14  
    11=== Background === 
    2 We already removed non-standard JavaScript code from the `adblockplus` repository (#312), but there is still some non-standard code left in the `buildtools` repository which is bundled with Firefox extensions. 
     2We already removed non-standard JavaScript code from the `adblockplus` repository (#312), and from `prefs.js` (#3418), but there is still some non-standard code left in the `buildtools` repository which is bundled with Firefox extensions. 
    33 
    44=== What to change === 
    55* Replace `{__proto__: null}` with `Object.create(null)` in `bootstrap.js.tmpl` and `lib/keySelector.js`. 
    66* Replace `for each (..)` with `for (.. of ..)` loops in `lib/keySelector.js`. 
    7 * Replace non-standard function expressions with arrow functions in `bootstrap.js.tmpl` and `lib/prefs.js`. 
    8 * Replace `__defineGetter__()` and `__defineSetter__()` with `Object.defineProperty()` in `lib/hooks.js` and `lib/prefs.js`. 
     7* Replace non-standard function expressions with arrow functions in `bootstrap.js.tmpl`. 
     8* Replace `__defineGetter__()` and `__defineSetter__()` with `Object.defineProperty()` in `lib/hooks.js`. 
    99* Replace `__lookupGetter__()` and `__lookupSetter__()` with `Object.getOwnPropertyDescriptor()` in `lib/hooks.js`.