Opened 6 years ago

Closed 6 years ago

#144 closed change (fixed)

Chrome development environment doesn't need to poll a port to recognize changes

Reported by: trev Assignee:
Priority: P4 Milestone: Adblock-Plus-1.8-for-Chrome-Opera-Safari
Module: Automation Keywords: goodfirstbug
Cc: Blocked By:
Blocking: Platform:
Ready: no Confidential: no
Tester: Verified working: no
Review URL(s):

Description

Background

Currently the Chrome development environment will attempt to connect on port 43816 to recognize that the extension needs to be reloaded. This is unnecessarily complicated and causes ugly error messages about failed connections. It also delays the build.py devenv command, it has to keep the port open for some time.

What to change

The Chrome packager can add a file devenvRevision.txt containing a random number to the development environment. chromeDevenvPoller__.js can load this file regularly and reload the extension if the file contents change.

Change History (1)

comment:1 Changed 6 years ago by trev

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Ready unset
  • Resolution set to fixed
  • Status changed from new to closed

This was fixed in #143.

Note: See TracTickets for help on using tickets.