Opened 5 years ago

Closed 3 years ago

#1445 closed change (rejected)

[Bubble UI] No type attribute in toolbarbutton

Reported by: saroyanm Assignee:
Priority: Unknown Milestone:
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: #181 Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

Description

Background

Because of 1062974 and 1063097 bugs in Firefox we can't use toolbarbutton's type attribute to open panel.
This ticket is also part of Bubble UI implementation #181.

What to change

Remove code that setting type attribute to toolbarbutton and use openPopup method to open panel with bubble UI.

Change History (2)

comment:1 Changed 4 years ago by philll

  • Platform changed from Firefox/Firefox Mobile to Firefox

Made Firefox and Firefox mobile available as seperate platforms.

comment:2 Changed 3 years ago by sebastian

  • Resolution set to rejected
  • Status changed from new to closed

With traditional Firefox extensions to be deprecated, and Adblock Plus for Firefox to be replaced with something that is build directly from adblockpluschrome the effort here becomes obsolete.

Note: See TracTickets for help on using tickets.