Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#1448 closed defect (fixed)

Domain is added even when "Remove selected" is clicked

Reported by: passbrains Assignee: raftel.ti@…
Priority: P3 Milestone: Adblock-Plus-1.8.11-for-Chrome-Opera-Safari
Module: User-Interface Keywords: goodfirstbug
Cc: Blocked By:
Blocking: #1526 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

https://github.com/adblockplus/adblockpluschrome/pull/9

Description (last modified by sebastian)

Adapted from https://www.passbrains.com/dashboard/view-ticket.php?ticket_no=AOP-98

Environment

Windows + Vista 64bit + Opera + English
ABP version Adblock Plus Version 1.8.5.1227

How to reproduce

  1. Install ABP extension on Opera.
  2. Go to  Extensions and Adblock Plus Options window.
  3. Select 'Whitelisted Domain' Tab.
  4. Write any string say 'xyz'  in first box.  Do not "Add Domain".
  5. Put cursor on second box so that whole box  which is empty is highlighted.  See image 1.
  6. Click on 'Remove Selected'
  7. Observe image2

Observed behaviour

Step 6 : Though 'Remove Selected' is clicked,  it adds the written string in whitelisted domain.

Expected behaviour

Step 6 : No string shall be removed, neither any string shall be added.

Attachments (2)

3659_1411328315_option-image1.jpg (79.3 KB) - added by passbrains 5 years ago.
3659_1411328315_option-image2.jpg (75.4 KB) - added by passbrains 5 years ago.

Download all attachments as: .zip

Change History (10)

Changed 5 years ago by passbrains

Changed 5 years ago by passbrains

comment:1 Changed 5 years ago by sebastian

  • Component changed from Unknown to User-Interface
  • Description modified (diff)
  • Keywords goodfirstbug added
  • Platform changed from Opera to Unknown
  • Priority changed from Unknown to P3
  • Ready set
  • Summary changed from 'Add Domain' option in Whitelisted domain behaves inapprorpiately to Domain is added even when "Remove selected" is clicked

comment:2 Changed 5 years ago by sven

  • Blocking 1526 added

comment:3 Changed 5 years ago by sergz

The same bug on the tab "Add your own filters"

comment:4 Changed 5 years ago by zeapo

This happens also in Chrome. I identified the culprit, will try to work on it in the following days.

comment:5 Changed 5 years ago by trev

  • Owner set to zeapo

comment:6 Changed 5 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed 5 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:8 Changed 5 years ago by sebastian

  • Owner changed from zeapo to raftel.ti@…
Note: See TracTickets for help on using tickets.