Opened 5 years ago

Closed 5 years ago

#1449 closed change (fixed)

Prefer Mercurial over Git

Reported by: matze Assignee: AAlvz
Priority: P4 Milestone:
Module: Automation Keywords: infrastructure hg git
Cc: fhd, trev, poz2k4444, AAlvz, mathias@… Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5025466448609280
https://github.com/AAlvz/infrastructure/commit/6b6b9cad86cc6a2c3ee5080c33033ce35559eb1b

Description

The ensure_dependencies.py script currently maintains all known repository types as a Python dict. This implies that the iteration order is defined by the hashing algorithm used - which currently causes git(1) being preferred over hg(1) when both are used in parallel.

We should introduce a convention that defines our priorities and thus which SCM to prefer (irregardless whether we want to change the current behavior or not, we should just control that ourselves in the first place) and actually promote Mercurial as primary choice in the script.

Change History (5)

comment:1 Changed 5 years ago by matze

  • Cc mathias@… added
  • Component changed from Unknown to Build-and-Release-Tools
  • Owner set to AAlvz
  • Priority changed from Unknown to P4
  • Review URL(s) modified (diff)

comment:2 Changed 5 years ago by matze

FYI: In the review-URLs of this ticket I've just linked a patch/commit we've created that should do the trick. We will, however, use this ticket to introduce @AAlvz to the upload.py script and codereview.adblockplus.org..

comment:3 Changed 5 years ago by matze

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 5 years ago by matze

@trev @fhd
Please make sure the changes are pushed to the buildtools repo.

@AAlvz
As soon as the buildtools repo has been updated this ticket can be closed.

comment:5 Changed 5 years ago by trev

  • Ready set
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.