Opened 4 years ago

#1450 new change

Show msg_update_missing for manual update checks

Reported by: fhd Assignee:
Priority: P3 Milestone:
Module: Adblock-Plus-for-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Android
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

Description

Background

We have currently no way of telling whether an update was available in AndroidUpdateCheckDoneCallback, so we can't show msg_update_missing in this case.

What to change

I can think of two options:

  1. We do something Android specific, e.g. some shared state between AndroidUpdateAvailableCallback and AndroidUpdateCheckDoneCallback- they are always invoked in that order.
  2. We pass this information to UpdateCheckDoneCallback in libadblockplus.

The second approach seems cleaner.

Change History (0)

Note: See TracTickets for help on using tickets.