Opened 4 years ago

Last modified 4 weeks ago

#1460 new change

Add a setting for not loading element hiding rules

Reported by: fhd Assignee:
Priority: P2 Milestone:
Module: Libadblockplus Keywords:
Cc: Blocked By: #2161
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

Description

Background

Not all clients are interested in element hiding - they could almost half libadblockplus' memory usage by not loading element hiding rules.

What to change

I see two API options:

  1. Add a field to AppInfo, e.g. supportsElementHiding (suggested by Wladimir).
  2. Add a setter and getter for a property, e.g. loadElementHidingRules.

I'd prefer the second variant. AppInfo is information about the app, while whether or not we load element hiding rules is more of a technical detail.

Change History (3)

comment:1 Changed 4 years ago by rjeschke

  • Blocking 303 removed

comment:2 Changed 3 years ago by fhd

  • Blocked By 2161 added

comment:3 Changed 4 weeks ago by arrowtricks

Your style is unique in comparison to other people I've read stuff from. Thanks for posting.

Java Training in Bangalore
iOS Training in Bangalore
Learn iOS App Development Bangalore
http://www.arrowtricks.com

Note: See TracTickets for help on using tickets.