Opened 4 years ago

Last modified 2 years ago

#1484 reviewing change

Go back to using the third-party version PassthroughApp

Reported by: sergz Assignee:
Priority: P4 Milestone: Adblock-Plus-for-Internet-Explorer-Next
Module: Adblock-Plus-for-Internet-Explorer Keywords:
Cc: Blocked By:
Blocking: Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29331579/
https://codereview.adblockplus.org/29331590/
https://codereview.adblockplus.org/29332980/

Description (last modified by eric@…)

Background

Eric says (source):

by modifying the SinkPolicy.* files we can no longer directly import future updates to PassthroughAPP.

What to change

Eric says (source):

Given that the code that was modified in those files was templated, it seems we could keep compatibility with the external code by using a template specialization rather than modify the external code itself.

Using template specialization is one possible method of accomplishing the larger goal, which is to use PassthroughAPP as distributed.

Change History (7)

comment:1 Changed 4 years ago by fhd

  • Blocking 1486 added

comment:2 Changed 4 years ago by oleksandr

  • Priority changed from Unknown to P4
  • Ready set

comment:3 Changed 3 years ago by eric@…

  • Description modified (diff)
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing
  • Summary changed from Override default impl of PassthruApp using template specialization to simplify update of PassthrughApp to Go back to using the third-party version PassthroughApp
  • Tester set to Unknown

comment:4 Changed 3 years ago by eric@…

  • Review URL(s) modified (diff)

comment:5 Changed 2 years ago by oleksandr

  • Milestone set to Adblock-Plus-for-Internet-Explorer-Next

comment:6 Changed 2 years ago by oleksandr

  • Blocking 1486 removed

comment:7 Changed 2 years ago by oleksandr

  • Milestone changed from Adblock-Plus-for-Internet-Explorer-1.6 to Adblock-Plus-for-Internet-Explorer-Next
Note: See TracTickets for help on using tickets.