Opened 5 years ago

Closed 3 years ago

#1486 closed change (fixed)

Move Passthru APP to a dedicated directory

Reported by: fhd Assignee:
Priority: P3 Milestone: Adblock-Plus-for-Internet-Explorer-1.6
Module: Adblock-Plus-for-Internet-Explorer Keywords:
Cc: oleksandr Blocked By:
Blocking: Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29330683/
https://codereview.adblockplus.org/29331574/

Description

Background

We currently have the source files of Passthru APP under src/plugin, next to ours. We should move them to a dedicated directory to make it more obvious that this is third party code, and to make it easier to update.

What to change

Move the Passthru APP source files to a dedicated directory. It might make sense to update them (e.g. to this version on GitHub) while we're at it. License files etc. should be included as well.

We don't have any other third party code in ABP for IE, so it's not obvious where to put this. I suggest /third_party/passthruapp (third_party being next to src and test, as in libadblockplus).

Change History (8)

comment:1 Changed 5 years ago by fhd

  • Platform changed from Unknown to Internet Explorer

comment:2 Changed 5 years ago by fhd

  • Cc oleksandr added

Oleksandr, please have a look and mark as ready if you agree.

comment:3 Changed 5 years ago by fhd

  • Blocked By 1484 added

comment:4 Changed 5 years ago by oleksandr

  • Ready set

comment:5 Changed 4 years ago by eric@…

  • Review URL(s) modified (diff)
  • Tester set to Unknown

comment:6 Changed 4 years ago by eric@…

  • Review URL(s) modified (diff)

comment:7 Changed 3 years ago by oleksandr

  • Milestone set to Adblock-Plus-for-Internet-Explorer-Next

comment:8 Changed 3 years ago by oleksandr

  • Blocked By 1484 removed
  • Resolution set to fixed
  • Status changed from new to closed

We have moved it to a dedicated directory, not under third_party, however. See #1484 for more details.

Note: See TracTickets for help on using tickets.