Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#1488 closed change (fixed)

Add pre-configurable preference to suppress the first run page in Chrome

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-1.9-for-Chrome-Opera-Safari
Module: Platform Keywords: growth, large-scale-deployments
Cc: mapx, simona, greiner Blocked By: #2040, #2171
Blocking: #542 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5251132066627584

Description (last modified by sebastian)

Background

In order to help administrators to deploy Adblock Plus in managed networks, we like to introduce pre-configurable preferences that can be configured via policies. For now that is only an option to prevent the first run page from showing up, which seems most important, since a lot of managed machines are reset on restart or login.

What to change

Implement the Managed Storage API. The key of the items retrieved, provides the name of a preference. The value should be used as default for that preference, overriding the hard-coded default value. However, values set by the user must override that default.

Add a managed storage schema declaring the boolean property suppress_first_run_page. Add that property as well to the Prefs object, and consider that preference when showing the first run page. If that preference is set to true the first run page must not show up.

Change History (18)

comment:1 Changed 5 years ago by sebastian

  • Blocking 278 added

comment:2 Changed 5 years ago by mapx

  • Description modified (diff)

comment:3 Changed 5 years ago by mapx

  • Cc mapx added

comment:4 Changed 5 years ago by sebastian

  • Owner sebastian deleted

comment:5 Changed 5 years ago by sebastian

  • Description modified (diff)

comment:6 Changed 5 years ago by simona

  • Keywords growth added

comment:7 Changed 5 years ago by simona

  • Cc simona added

comment:8 Changed 5 years ago by simona

  • Keywords large-scale-deployments added

comment:9 Changed 5 years ago by sebastian

  • Blocked By 2040 added

comment:10 Changed 5 years ago by sebastian

  • Owner set to sebastian

comment:11 Changed 5 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:12 Changed 5 years ago by sebastian

  • Blocked By 2171 added

comment:13 Changed 5 years ago by sebastian

  • Blocked By 1487 removed
  • Description modified (diff)
  • Summary changed from Enable pre-configurable properties in Chrome to Add pre-configurable preference to suppress the first run page in Chrome

comment:14 Changed 5 years ago by sebastian

  • Blocking 278 removed

comment:15 Changed 5 years ago by greiner

  • Cc greiner added

comment:16 Changed 5 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:17 Changed 5 years ago by Ross

This didn't work for me on a local (non-domain) Windows machine. Chrome appears to completely ignore registry keys for policies if they were not added via the Windows Group Policy Editor. Tested that out by attempting set an actual Chrome policy, (instead of extension policy), Chrome did indeed ignore it.

Attempted to test on VM's but could only set local policy. Going to try a template as suggested below / ask VM provider about changing settings.

Chrome 42.0.2311.90 / Windows 8.1 x64 / ABP: 1.8.12.1421

Last edited 5 years ago by Ross (previous) (diff)

comment:18 Changed 5 years ago by sebastian

According to the documentation provisioning policy via registry is only supported Windows instances that are joined to an Active Directory domain. I've updated the devbuild announcement receptively. Alternatively, one could write an ADM/ADMX template to configure that policy via GPO Editor.

Note: See TracTickets for help on using tickets.