Opened 5 years ago

Closed 4 years ago

#1490 closed change (fixed)

Enable pre-configurable properties in Internet Explorer

Reported by: sebastian Assignee: oleksandr
Priority: P3 Milestone: Adblock-Plus-for-Internet-Explorer-1.5
Module: Adblock-Plus-for-Internet-Explorer Keywords: growth, large-scale-deployments
Cc: mapx, oleksandr@…, simona, sebastian, sergz Blocked By:
Blocking: #542, #1491 Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29317083/

Description (last modified by sebastian)

Background

In order to help administrators to deploy Adblock Plus in managed networks, we introduce a mechanism to enable pre-configurable properties. While the foundation is implemented in the core code (#1487), the way pre-configured properties are stored is platform-specific.

What to change

Implement the hooks provided in the core code to retrieve pre-configured properties by reading those properties from a file on the disk.

Change History (21)

comment:1 Changed 5 years ago by mapx

  • Description modified (diff)

comment:2 Changed 5 years ago by mapx

  • Cc mapx added

comment:3 Changed 5 years ago by sebastian

  • Description modified (diff)

comment:4 Changed 5 years ago by sebastian

  • Blocking 1491 added

comment:5 Changed 5 years ago by oleksandr

  • Cc oleksandr@… added
  • Platform changed from Unknown to Internet Explorer

comment:6 Changed 5 years ago by simona

  • Keywords growth added

comment:7 Changed 5 years ago by oleksandr

  • Owner set to oleksandr

comment:8 Changed 5 years ago by simona

  • Cc simona added

comment:9 Changed 5 years ago by simona

  • Keywords large-scale-deployments added

comment:10 Changed 5 years ago by oleksandr

  • Priority changed from P3 to P2

comment:11 Changed 5 years ago by oleksandr

  • Owner oleksandr deleted

comment:12 Changed 5 years ago by oleksandr

  • Priority changed from P2 to P3

Decreasing priority, since it's not on the roadmap and blocking issues are on hold.

comment:13 Changed 5 years ago by sebastian

  • Blocked By 1487 removed

comment:14 Changed 5 years ago by sebastian

  • Cc sebastian added
  • Ready unset

Since #1487 is obsolete, we need to come up with a different approach.

comment:15 Changed 5 years ago by sebastian

So how about group policies, similar to how you can configure Chrome?

comment:16 Changed 5 years ago by oleksandr

In IE the simplest way would be to use Group Policy to deliver the prefs.json that has some special settings (no updates, no FRP). However, alternatively, based on how Chrome stores Managed Storage settings on Windows we can use the same settings with Chrome and read them from the registry. That way admins would set one setting for both Chrome and IE in something like:

HKEY_LOCAL_MACHINE\Software\Policies\Google\Chrome\3rdparty\extensions\gihmafigllmhbppdfjnfecimiohcljba\policy\

I would prefer to deliver prefs.json just with 2 extra settings for simplicity, but either way is fine with me

comment:17 Changed 5 years ago by oleksandr

Removing accidental double comment.

Last edited 5 years ago by oleksandr (previous) (diff)

comment:18 Changed 5 years ago by sergz

  • Cc sergz added

comment:19 Changed 4 years ago by oleksandr

  • Owner set to oleksandr

comment:20 Changed 4 years ago by oleksandr

  • Ready set
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:21 Changed 4 years ago by oleksandr

  • Milestone set to Adblock-Plus-for-Internet-Explorer-1.5
  • Resolution set to fixed
  • Status changed from reviewing to closed
  • Tester set to Unknown
Note: See TracTickets for help on using tickets.