Opened 5 years ago

Closed 5 years ago

#1495 closed change (fixed)

Allow Puppet sitescripts and ::configfragment to be used with templates

Reported by: matze Assignee: matze
Priority: P2 Milestone:
Module: Unknown Keywords: sitescripts
Cc: trev, fhd, AAlvz, poz2k4444 Blocked By:
Blocking: #240 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6122106488094720/
https://github.com/mjhennig/adblockplus-infrastructure/pull/18

Description

Background

Currently, both class {'sitescripts': } and sitescripts::configfragment() only allow for source locations being specified (using the $sitescriptsini_source parameter). This cannot be used in connection with e.g. the Puppet template() function, which prevents easy creation and customization of sitescripts.ini files.

What to change

Incorporate a $sitescriptsini_content parameter that can be used instead of $sitescriptsini_source in both the sitescripts class and the sitescripts::configfragment type.

Change History (5)

comment:1 Changed 5 years ago by matze

  • Review URL(s) modified (diff)

comment:2 Changed 5 years ago by matze

  • Review URL(s) modified (diff)

comment:3 Changed 5 years ago by matze

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 5 years ago by matze

  • Priority changed from Unknown to P2
  • Ready set

(Applied same priority as in ticket #240, since these changes are to be included in there.)

comment:5 Changed 5 years ago by matze

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.