Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#1496 closed defect (fixed)

Some Flash videos broken again with Chrome 39

Reported by: sebastian Assignee: sebastian
Priority: P1 Milestone: Adblock-Plus-1.8.7-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6089548756942848

Description

Environment

Chrome 39.0.2171.36 (beta)

How to reproduce

see #1372

Observed behaviour

Since Chrome 38 requests loading <object> elements like Flash, and requests initiated by those third-party plugins are mistakenly reported by Chrome's webRequest API with the type other instead object.

This can lead to false negatives as well as false positives when using Adblock Plus. In the worst case it results in breaking entire Flash videos, as reported in #1372.

We limited the workaround we originally implemented to Chrome 38, in the hope that Google will fix that issue before Chrome 39 is released. However, Chrome 39 is in beta for two weeks now, and it is rather unlikely that this issue will still be fixed in the beta.

Expected behaviour

Adblock Plus should work around Chrome bug 410382, on Chrome 39 as it already does for Chrome 38.

Change History (3)

comment:1 Changed 5 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 5 years ago by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:3 Changed 5 years ago by sebastian

  • Ready set
Note: See TracTickets for help on using tickets.