Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#1510 closed change (fixed)

Stop using OS.File.readTo()

Reported by: trev Assignee:
Priority: P1 Milestone: Adblock-Plus-2.6.6-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: mapx Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6083164824928256

Description (last modified by trev)

Background

We are currently using OS.File.readTo() when reading from files. [Bug 1075438](https://bugzilla.mozilla.org/show_bug.cgi?id=1075438) is about to remove that method however.

What to change

Use OS.File.read() instead - this will create a new buffer for each read, so increasing buffer size might be a good idea.

Testing hints

The bug makes Adblock Plus completely dysfunctional in current Firefox nightlies - the filters aren't being loaded, consequently Adblock Plus options don't show any data. With this change the data should load correctly when Adblock Plus starts.

This change could also have an impact on startup performance, even though that's rather unlikely.

Change History (5)

comment:1 Changed 5 years ago by mapx

  • Cc mapx added

comment:2 Changed 5 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 5 years ago by trev

  • Description modified (diff)
  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed 5 years ago by trev

  • Description modified (diff)

comment:5 Changed 4 years ago by philll

  • Platform changed from Firefox/Firefox Mobile to Firefox

Made Firefox and Firefox mobile available as seperate platforms.

Note: See TracTickets for help on using tickets.