Opened on 10/29/2014 at 02:43:16 PM

Closed on 11/03/2014 at 11:40:28 AM

Last modified on 05/20/2015 at 02:22:39 PM

#1510 closed change (fixed)

Stop using OS.File.readTo()

Reported by: trev Assignee:
Priority: P1 Milestone: Adblock-Plus-2.6.6-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: mapx Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

Description (last modified by trev)


We are currently using OS.File.readTo() when reading from files. [Bug 1075438]( is about to remove that method however.

What to change

Use instead - this will create a new buffer for each read, so increasing buffer size might be a good idea.

Testing hints

The bug makes Adblock Plus completely dysfunctional in current Firefox nightlies - the filters aren't being loaded, consequently Adblock Plus options don't show any data. With this change the data should load correctly when Adblock Plus starts.

This change could also have an impact on startup performance, even though that's rather unlikely.

Attachments (0)

Change History (5)

comment:1 Changed on 10/29/2014 at 03:42:24 PM by mapx

  • Cc mapx added

comment:2 Changed on 10/30/2014 at 10:03:38 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 11/03/2014 at 11:40:28 AM by trev

  • Description modified (diff)
  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed on 11/03/2014 at 12:16:48 PM by trev

  • Description modified (diff)

comment:5 Changed on 05/20/2015 at 02:22:39 PM by philll

  • Platform changed from Firefox/Firefox Mobile to Firefox

Made Firefox and Firefox mobile available as seperate platforms.

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Note: See TracTickets for help on using tickets.