Opened 5 years ago

Closed 5 years ago

#1516 closed defect (fixed)

Error when moving "Block element" dialog

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-1.8.8-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6174409794519040

Description

Environment

Chrome, Opera, Safari (all versions)
Probably since Adblock Plus 1.7.4

How to reproduce

  1. Go to any website (e.g. https://google.com/)
  2. Click on the ABP icon
  3. Choose "Block element"
  4. Click on any element (e.g. the Google logo)
  5. Position the mouse pointer anywhere on the dialog where no UI elements are
  6. Keep left mouse button pressed and move the mouse in any direction
  7. Release the mouse button

Observed behaviour

The dialog stays in its initial position. However, for every pixel you moved the mouse, ReferenceError: request is not defined is logged to the JavaScript console.

Expected behaviour

The dialog should move to the position where you dragged it, as it did in earlier version of Adblock Plus. No JavaScript error should occur.

Change History (2)

comment:1 Changed 5 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 5 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.