Opened 5 years ago

Closed 5 years ago

#1518 closed change (fixed)

Get rid of deprecated code using webkitNotifications

Reported by: sebastian Assignee: sebastian
Priority: P4 Milestone: Adblock-Plus-1.8.10-for-Chrome-Opera-Safari
Module: Platform Keywords: goodfirstbug
Cc: saroyanm Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6182748523855872

Description (last modified by sebastian)

Background

When we initially implemented the anti-adblock notification (#174), we used webkitNotifications as fallback, when rich notifications for extensions aren't available.

But webkitNotifications.createHTMLNotification() has been dropped in Chrome 28, and older versions of Chrome aren't supported by Adblock Plus anymore. Therefore this code can be removed now.

Also webkitNotifications.createNotification() is deprecated, and new Notification() should be used instead.

What to change

  • Remove code using webkitNotifications.createHTMLNotification().
  • Adapt code using webkitNotifications.createNotification() to use new Notification() instead.

Change History (5)

comment:1 Changed 5 years ago by sebastian

  • Description modified (diff)
  • Owner set to sebastian
  • Summary changed from Remove fallback code using createHTMLNotification to Get rid of deprecated code using webkitNotifications

comment:2 Changed 5 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 5 years ago by sebastian

  • Description modified (diff)

comment:4 Changed 5 years ago by sebastian

  • Description modified (diff)

comment:5 Changed 5 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.