Opened 5 years ago

Closed 5 years ago

#1522 closed change (fixed)

Use classList attribute when generating element hiding filters

Reported by: sebastian Assignee: sebastian
Priority: P4 Milestone: Adblock-Plus-1.8.8-for-Chrome-Opera-Safari
Module: Platform Keywords: goodfirstbug
Cc: greiner Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5269160074412032

Description

Background

The code that generates element hiding filters based on the class attribute, when using "Block element" functionality, is splitting the value of the className property to retrieve a list of classes. However, since Chrome 8 and Safari 5.1 we can use the classList attribute, which already provides a list of classes, instead rolling our own logic to split classes.

What to change

Use classList attribute instead splitting className to retrieve a list of classes.

Change History (3)

comment:1 Changed 5 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing
  • Summary changed from Make classList attribute when generating element hiding filters to Use classList attribute when generating element hiding filters

comment:2 Changed 5 years ago by sebastian

  • Owner set to sebastian

comment:3 Changed 5 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.