Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#1528 closed change (fixed)

Implement interface for new options page

Reported by: greiner Assignee: greiner
Priority: P2 Milestone:
Module: Platform Keywords:
Cc: Blocked By:
Blocking: #1524 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/4864767881641984/

Description (last modified by greiner)

Background

Currently, we are accessing background objects directly from the UI which causes all sorts of problems in Safari. We can simplify that by sending messages back and forth between the UI and the extension's background page.

This is part of the options page redesign #1524 so we need to implement any options page interactions with the extension.

What to change

  • Determine options page requirements and design an appropriate interface (see design document)
  • Extend messaging mechanism initially implemented as part of #1663 with methods required by options page
    • app.get (addonVersion)
    • app.listen (addSubscription, loaded)
    • filters.add
    • filters.get
    • filters.listen
    • filters.remove
    • prefs.get
    • subscriptions.add
    • subscriptions.remove
  • Add to the mock implementation of the extension interface for testing the UI

What to test

Make sure that the first-run page still works as expected:

  • It should be possible to toggle features on and off
  • Clicking share buttons should open social media pages when "Remove Social Media Buttons" feature is enabled and otherwise show share overlay
  • Clicking on links should open referenced page (including link to options page)
  • Predefined messages should appear as described in the README file

The rest should be covered as part of #1526.

Change History (10)

comment:1 Changed 3 years ago by greiner

  • Owner set to greiner

comment:2 Changed 3 years ago by greiner

  • Priority changed from Unknown to P2

comment:3 Changed 3 years ago by sven

  • Keywords 2014q4 removed

comment:4 Changed 3 years ago by greiner

  • Description modified (diff)

comment:5 Changed 3 years ago by sebastian

As far as I know, we have a pretty good idea how we want to implement that, by now. So can you please add the missing details to the issue description, that we can set this issue to ready?

comment:6 Changed 3 years ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed 3 years ago by greiner

  • Description modified (diff)
  • Ready set

comment:8 Changed 3 years ago by greiner

  • Description modified (diff)

comment:9 Changed 3 years ago by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:10 Changed 3 years ago by greiner

  • Description modified (diff)
Note: See TracTickets for help on using tickets.