Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#1529 closed change (fixed)

Support case-insensitive header comparison in PluginWbPassThrough.cpp

Reported by: oleksandr Assignee: Mailkov
Priority: P4 Milestone: Adblock-Plus-for-Internet-Explorer-1.4
Module: Adblock-Plus-for-Internet-Explorer Keywords: goodfirstbug
Cc: Blocked By:
Blocking: Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

Description

Background

Taken from: http://codereview.adblockplus.org/4974480757620736/diff/5630721452408832/src/plugin/PluginWbPassThrough.cpp
Currently when extracting header in PluginWbPassThrough.cpp our code is case-sensitive. It's fine for now, but would be safer to have case-insensitive code.

What to change

Change the header extraction code to case-insensitive one.

Change History (8)

comment:1 Changed 4 years ago by Mailkov

I would like to work on this change.

comment:2 Changed 4 years ago by oleksandr

  • Owner set to Mailkov

Yaay! :)

comment:3 Changed 4 years ago by Mailkov

Last edited 4 years ago by Mailkov (previous) (diff)

comment:4 Changed 4 years ago by Mailkov

Can you review this issue? Thanks

comment:5 Changed 4 years ago by Mailkov

Change pull request https://github.com/adblockplus/adblockplusie/pull/7
Can you review this issue? Thanks !!!

comment:6 Changed 4 years ago by Mailkov

New pull request https://github.com/adblockplus/adblockplusie/pull/8
Can you merge this? Thanks !!!

comment:7 Changed 4 years ago by oleksandr

  • Resolution set to fixed
  • Status changed from new to closed

comment:8 Changed 4 years ago by oleksandr

  • Milestone set to Adblock-Plus-for-Internet-Explorer-1.4
Note: See TracTickets for help on using tickets.