Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#1530 closed change (fixed)

Improve detecting of subrequest issued by flash addon

Reported by: sergz Assignee: sergz
Priority: P3 Milestone: Adblock-Plus-for-Internet-Explorer-1.3
Module: Adblock-Plus-for-Internet-Explorer Keywords:
Cc: oleksandr Blocked By:
Blocking: Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5506777797885952/

Description

Background

Now there is a heuristic based on flags from bind info (see PluginWbPassThrough.cpp IsFlashRequest) but flash plugin adds x-flash-version: <command separated version> header into pszAdditionalHeaders. The heuristic is still good for other cases but it would be more reliable to test the existence of that header as well.

Change History (5)

comment:1 Changed 5 years ago by oleksandr

  • Priority changed from Unknown to P3
  • Ready set

comment:2 Changed 5 years ago by sergz

  • Owner set to sergz

comment:3 Changed 5 years ago by sergz

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 5 years ago by sergz

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 5 years ago by fhd

  • Milestone set to Adblock-Plus-for-Internet-Explorer-1.3
Note: See TracTickets for help on using tickets.