Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#1534 closed change (fixed)

Replace ABP icon with new one - for Firefox

Reported by: sven Assignee: trev
Priority: P3 Milestone: Adblock-Plus-2.6.8-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: trev, greiner Blocked By:
Blocking: #1533 Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5086035738361856/

Description (last modified by trev)

Background

We've created a new icon that was announced and discussed in our ​blog and in our ​forum. After some improvements, these icons are ready to implement now.

What to change

Replace the current ABP icons with the new ones (consider: all images are overly large, they should go through pngout first.):

RepoFilenameSize(px)UseCaseNewFile
adblockplusicon.png48x48about:addons48px-active_v1_2.png
adblockplusicon64.png64x64about:addons64px-active_v1_2.png
adblockpluschrome/skin/abp-status.png24x48Toolbar icon (default + inactive)24px-active_inactive_v1_2.png
adblockpluschrome/skin/abp-status-16.png16x32Toolbar icon (default + inactive)16px-active_inactive_v1_2.png
adblockpluschrome/skin/abp-status-32.png32x64Toolbar icon (default + inactive)32px-active_inactive_v1_2.png

Attachments (5)

48px-active_v1_2.png (3.4 KB) - added by sven 5 years ago.
64px-active_v1_2.png (4.3 KB) - added by sven 5 years ago.
16px-active_inactive_v1_2.png (18.4 KB) - added by sven 5 years ago.
24px-active_inactive_v1_2.png (18.9 KB) - added by sven 5 years ago.
32px-active_inactive_v1_2.png (19.3 KB) - added by sven 5 years ago.

Download all attachments as: .zip

Change History (31)

comment:1 Changed 5 years ago by sven

  • Description modified (diff)

comment:2 Changed 5 years ago by sven

  • Blocking 1533 added

comment:3 Changed 5 years ago by fhd

  • Component changed from User-Interface to Adblock-Plus-for-Firefox
  • Platform changed from Unknown to Firefox/Firefox Mobile

comment:4 Changed 5 years ago by fhd

  • Priority changed from P2 to P3

comment:5 Changed 5 years ago by fhd

Unsetting ready for now - Sven would still like to go over this with the new designer in January.

comment:6 Changed 5 years ago by sven

  • Description modified (diff)
  • Summary changed from Replace ABP icon with new one (v.1.0) - for Firefox to Replace ABP icon with new one (v.1.1) - for Firefox

comment:7 Changed 5 years ago by sven

We improved the 16px and the 19px version (v1.1). It's ready to implement now.

comment:8 Changed 5 years ago by trev

  • Cc trev added

Sven, we also need 48x48 and 64x64 for Firefox ("enabled" only).

comment:9 Changed 5 years ago by sven

We will upload it this Wednesday at the latest

comment:10 Changed 5 years ago by christiane

both files attached.

comment:11 Changed 5 years ago by philll

  • Resolution set to invalid
  • Status changed from new to closed

Please provide a proper Issue description. There are four attachments and way more image files in those. It is unlikely that a developer will guess correctly which of those should be used where and replace what.

comment:12 Changed 5 years ago by trev

  • Description modified (diff)

After looking through the archives, I noticed that 24x24 icons are missing as well.

comment:13 Changed 5 years ago by sven

The 48px and 64px icon will need improvements since they aren't used for toolbar icons. This was not clear after @trev's comment: "we also need 48x48 and 64x64 for Firefox ("enabled" only)". We work on that.

comment:14 Changed 5 years ago by sven

  • Description modified (diff)

comment:15 Changed 5 years ago by sven

  • Description modified (diff)

comment:16 follow-up: Changed 5 years ago by sven

The "48px-active_v1_1.png"​ and "64px-active_v1_1.png​" icons should be removed from the attachements since they are not up to date anymore and could cause confusions.

Last edited 5 years ago by sven (previous) (diff)

comment:17 in reply to: ↑ 16 Changed 5 years ago by greiner

  • Cc greiner added

Please only upload those images which are relevant for an issue - if necessary already in the form of a sprite so that they can be added without modifying the images themselves to ensure that images are added exactly as they were provided. You can find all relevant images for this issue in the adblockplus repository (can be downloaded by clicking on "zip" link).

Finally, I noticed that none of the issues currently listed under #1533 are about replacing the icon on the first-run page due to it being part of the adblockplusui repository.

Replying to sven:

The "48px-active_v1_1.png"​ and "64px-active_v1_1.png​" icons should be removed from the attachements since they are not up to date anymore and could cause confusions.

This is not necessary since only the relevant attachments should be linked to in the issue description and therefore considered.

comment:18 Changed 5 years ago by sven

This is not necessary since only the relevant attachments should be linked to in the issue description and therefore considered.

Agree.

Changed 5 years ago by sven

Changed 5 years ago by sven

Changed 5 years ago by sven

Changed 5 years ago by sven

Changed 5 years ago by sven

comment:19 Changed 5 years ago by sven

  • Description modified (diff)
  • Resolution invalid deleted
  • Status changed from closed to reopened

comment:20 Changed 5 years ago by trev

  • Description modified (diff)
  • Ready set

comment:21 Changed 5 years ago by trev

  • Summary changed from Replace ABP icon with new one (v.1.1) - for Firefox to Replace ABP icon with new one - for Firefox

comment:22 Changed 5 years ago by trev

  • Owner set to trev

comment:23 Changed 5 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from reopened to reviewing

comment:24 Changed 5 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:25 Changed 5 years ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next

comment:26 Changed 4 years ago by philll

  • Platform changed from Firefox/Firefox Mobile to Firefox

Made Firefox and Firefox mobile available as seperate platforms.

Note: See TracTickets for help on using tickets.