#1538 closed change (fixed)
Replace ABP icons with new ones - for Internet Explorer
Reported by: | sven | Assignee: | sven |
---|---|---|---|
Priority: | P2 | Milestone: | Adblock-Plus-for-Internet-Explorer-1.5 |
Module: | Adblock-Plus-for-Internet-Explorer | Keywords: | |
Cc: | oleksandr | Blocked By: | |
Blocking: | #1533 | Platform: | Internet Explorer |
Ready: | yes | Confidential: | no |
Tester: | Verified working: | no | |
Review URL(s): |
Description (last modified by sven)
Background
We've created a new icon that was announced and discussed in our blog and in our forum.
What to change
Replace the current ABP icons with the new ones:
Repo | Filename | Size(px) | UseCase | NewFile |
adblockplusie | src/res/blocking.ico | 32x32 | Status bar in high DPI setting and Add/Remove programs List View | active_32_v_1_1.ico |
adblockplusie | src/res/deactivated.ico | 32x32 | IE's status bar high DPI setting | inactive_32_v_1_1.ico |
adblockplusie | src/res/not-blocking.ico | 32x32 | IE's status bar high DPI setting | inactive_32_v_1_1.ico |
adblockplusie | src/res/blocking.ico | 19x19 | Status bar and Add/Remove programs List View | active_19_v_1_1.ico |
adblockplusie | src/res/deactivated.ico | 19x19 | IE's status bar | inactive_19_v_1_1.ico |
adblockplusie | src/res/not-blocking.ico | 19x19 | IE's status bar | inactive_19_v_1_1.ico |
adblockplusie | src/res/blocking.ico | 16x16 | Windows Explorer - details and list views | active_16_v_1_1.ico |
adblockplusie | src/res/blocking.ico | 32x32 | Windows Explorer - icon view, Desktop | active_32_v_1_2.ico |
adblockplusie | src/res/blocking.ico | 48x48 | Windows Explorer, tiles and thumbnails | active_48_v_1_2.ico |
adblockplusie | src/res/blocking.ico | 128x128 | Add/Remove programs - Medium icons | active_128_v_1_2.ico |
adblockplusie | src/res/blocking.ico | 256x256 | Add/Remove programs - Large icons, Desktop, Windows Explorer | active_256_v_1_2.ico |
Attachments (11)
Change History (39)
Changed 5 years ago by sven
comment:1 Changed 5 years ago by sven
- Blocking 1533 added
comment:2 Changed 5 years ago by oleksandr
- Platform changed from Unknown to Internet Explorer
- Ready set
comment:3 Changed 5 years ago by fhd
- Component changed from User-Interface to Adblock-Plus-for-Internet-Explorer
comment:4 Changed 5 years ago by fhd
- Priority changed from P2 to P3
comment:5 Changed 5 years ago by fhd
- Ready unset
Unsetting ready for now - Sven would still like to go over this with the new designer in January.
comment:6 Changed 5 years ago by eric@…
The attached file only contains .png files. These are adequate for web pages, but the code uses .ico files for the status bar and the icon within the control panel that lists installed programs ("Programs and Features" or "Add/Remove Programs" depending on Windows version).
comment:7 Changed 5 years ago by sven
- Description modified (diff)
- Summary changed from Replace ABP icon with new one (v.1.0) - for Internet Explorer to Replace ABP icon with new one (v.1.1) - for Internet Explorer
comment:8 Changed 5 years ago by sven
We improved the 16px and the 19px version (v1.1). I also created .ico files for the Internet Explorer version. It should be ready to implement now.
comment:9 Changed 5 years ago by sven
- Cc oleksandr added
comment:10 Changed 5 years ago by oleksandr
- Milestone set to Adblock-Plus-for-Internet-Explorer-1.4
- Owner set to oleksandr
- Priority changed from P3 to P2
- Ready set
comment:11 Changed 5 years ago by oleksandr
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:12 Changed 5 years ago by trev
@Sven, MSIE installer also needs a 64x64 icon.
comment:13 Changed 5 years ago by sven
We will upload it this Wednesday at the latest
comment:14 Changed 5 years ago by oleksandr
Actually, what we need is a whole range of icons: 256x256, 128x128, 48x48, 32x32, 24x24, 16x16. Please see here for more detail. Please note that we don't really need the 64x64 icon.
I can produce the multidimensional icon from a set of icons, if required.
comment:15 Changed 5 years ago by oleksandr
- Owner changed from oleksandr to sven
comment:16 Changed 5 years ago by sven
@oleksandr please insert all used sizes and use cases into this spreadsheet. We will create the necessary icons then. Please don't forget the "use cases" section, because icons which are no toolbar-icons will be designed differently.
comment:17 Changed 5 years ago by philll
- Ready unset
comment:18 Changed 5 years ago by oleksandr
Added icon sizes and context.
comment:19 Changed 5 years ago by eric@…
#1236 also requires a multiresolution icon.
comment:20 Changed 5 years ago by eric@…
@sven I looked at the reference spreadsheet; it's view-only for me. This Stack Overflow question, though, has all the information required to make a good multiresolution icon for the various versions of Windows:
comment:21 Changed 5 years ago by sven
@eric, sorry I forgot to give you the permissions to edit the spreadsheet. You should be able to do so now. I would edit the spreadsheet by myself but i will not have the time to do so in the next days. So if someone of you @eric or @olek have time to complete the spreadsheet that would be nice.
comment:22 Changed 5 years ago by oleksandr
@sven the spreadsheet is complete
Changed 5 years ago by sven
Changed 5 years ago by sven
Changed 5 years ago by sven
Changed 5 years ago by sven
Changed 5 years ago by sven
Changed 5 years ago by sven
Changed 5 years ago by sven
comment:23 Changed 5 years ago by sven
- Description modified (diff)
- Status changed from reviewing to reopened
- Summary changed from Replace ABP icon with new one (v.1.1) - for Internet Explorer to Replace ABP icons with new ones - for Internet Explorer
comment:24 Changed 5 years ago by sven
The 32x32px and 256x256px icon will be created and uploaded in the next days.
Changed 5 years ago by sven
Changed 5 years ago by sven
comment:25 Changed 5 years ago by sven
- Description modified (diff)
comment:26 Changed 5 years ago by sven
should be ready to implement now :)
comment:27 Changed 5 years ago by oleksandr
- Ready set
- Resolution set to fixed
- Status changed from reopened to closed
Thanks, @sven! Looks great! This is pushed now.
comment:28 Changed 5 years ago by oleksandr
- Milestone changed from Adblock-Plus-for-Internet-Explorer-1.4 to Adblock-Plus-for-Internet-Explorer-Next
ABP icons v.1.0