Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#1540 closed defect (fixed)

Utility method for loading text is at the wrong location

Reported by: rjeschke Assignee: rjeschke
Priority: P2 Milestone: Adblock-Plus-for-Android-1.3
Module: Adblock-Plus-for-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Android
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5662276015095808

Description

There's a method called appendRawTextFile which is currently declared in class AdblockPlus but only used in AboutDialog and ProxyConfigurationActivity.

The correct location for this method should be Utils, and while we're on it we could directly close the resources correctly.

Change History (5)

comment:1 Changed 5 years ago by rjeschke

  • Review URL(s) modified (diff)

comment:2 Changed 5 years ago by rjeschke

  • Resolution set to fixed
  • Status changed from new to closed

comment:3 Changed 5 years ago by philll

What could possibly be tested here?

comment:4 Changed 5 years ago by rjeschke

It could be tested if long texts in the app (like in the about dialogue) still appear correctly.

comment:5 Changed 5 years ago by rjeschke

  • Milestone set to Adblock-Plus-for-Android-1.3
Note: See TracTickets for help on using tickets.