Opened 6 years ago

Closed 3 years ago

#1546 closed change (fixed)

Change the signature of native callback functions

Reported by: sergz Assignee:
Priority: Unknown Milestone:
Module: Libadblockplus Keywords:
Cc: Blocked By:
Blocking: #1197 Platform: Unknown
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):



The recent signature is void FunctionCallback(const FunctionCallbackInfo<Value>& info); thus no return value and instead of v8::Arguments v8::FunctionCallbackInfo.

  • To return value one has to use info.GetReturnValue().Set(value to return);.
  • To throw an exception one has to call isolate->ThrowException(value).
  • To return v8::Undefined - do nothing.

Change History (1)

comment:1 Changed 3 years ago by sergz

  • Resolution set to fixed
  • Status changed from new to closed
  • Tester set to Unknown

Done as a part of #4907.

Note: See TracTickets for help on using tickets.