Opened 5 years ago

Closed 2 years ago

#1548 closed change (worksforme)

Update gyp to the recent version

Reported by: sergz Assignee:
Priority: Unknown Milestone:
Module: Libadblockplus Keywords:
Cc: fhd Blocked By:
Blocking: #1197 Platform: Unknown
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by sergz)

Background

Current version of gyp does not allow to generate solution/project files for MS Visual Studio 2013.

Note

  • with new gyp there is a trouble. The generated project contains in the custom action "--random-seed" "..\..\..\..\..\..\third_party\v8\tools\gyp\314159265" instead of "--random-seed" "314159265" (the relative path should not be added). Its source is v8_random_seed in libadblockplus\third_party\v8\tools\gyp\v8.gyp.
  • there are our changes in gyp which should be rebased (see https://github.com/adblockplus/gyp/commit/8035ac91ddef78ed6fae19fca67702934c5322a3, it's in fix-issue-339 branch)

Change History (8)

comment:1 Changed 4 years ago by sergz

  • Cc fhd added
  • Description modified (diff)
  • Tester set to Unknown

comment:2 Changed 4 years ago by fhd

  • Resolution set to fixed
  • Status changed from new to closed

Updated. I had to push the entire tree as a new head to hg.adblockplus.org/gyp, because the ID mapping has changed since that clone was first created. By keeping the old head, the old refs still work.

comment:3 Changed 4 years ago by fhd

  • Resolution fixed deleted
  • Status changed from closed to reopened

We still need Wladimir's old patch to keep the Android build on working. I'll have to merge all changes since then into that branch to keep the old refs working.

comment:4 Changed 4 years ago by fhd

  • Resolution set to fixed
  • Status changed from reopened to closed

Merged master into fix-issue-339.

comment:5 Changed 4 years ago by sergz

  • Resolution fixed deleted
  • Status changed from closed to reopened

It's still relevant because our fix in gyp does not help here.

comment:6 Changed 4 years ago by eric@…

Issue description says "current version of gyp". What version of gyp is that? Which one are we updating to?

comment:7 Changed 2 years ago by sergz

Gyp is updated to https://github.com/adblockplus/gyp/commit/8ffe7e7b1b82890a7e9ea21176bf039b6c53167b (which is based on 70fa8bbeb2921c51b34598d3eda8e5fc485e952c, 2 years ago (2015-11-12 23:09:31), and includes our changes) as a part of #4907. Although this version is not the recent one, the development of gyp is not active and it seems there is nothing very essential for us there.

So, current version of gyp allows to generate solutions for VS 2013 (what this issue is about, but this version is not relevant anymore) as well as for VS 2015 (what is actually used and it even works with VS 2017). Therefore this issue can be closed, please create a new one when a required functionality appears in gyp repository and there is a demand in it.

comment:8 Changed 2 years ago by sergz

  • Resolution set to worksforme
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.