Opened 5 years ago

Closed 5 years ago

#1549 closed change (fixed)

Initialize v8::V8

Reported by: sergz Assignee:
Priority: Unknown Milestone:
Module: Libadblockplus Keywords:
Cc: Blocked By:
Blocking: #1197 Platform: Unknown
Ready: no Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/4978827532959744/

Description (last modified by sergz)

Background

The recent v8 does not automatically initialize thread local storage required by v8::Isolate.

If v8::V8 is not initialized then thread_data_table_ is nullptr, the callstack is

>	tests.exe!v8::internal::Isolate::Isolate(bool enable_serializer) Line 1515	C++
 	tests.exe!v8::Isolate::New(const v8::Isolate::CreateParams & params) Line 6594	C++
 	tests.exe!AdblockPlus::IsolateManagerJsEngine::IsolateManagerJsEngine() Line 62	C++
 	tests.exe!AdblockPlus::IsolateScopeJsEngine::IsolateScopeJsEngine() Line 76	C++
 	tests.exe!AdblockPlus::ContextScopeJsEngine::ContextScopeJsEngine()	C++
 	tests.exe!AdblockPlus::JsEngine::JsEngine(AdblockPlus::JsEngine::PrivateCtrArg __formal) Line 74	C++
 	tests.exe!std::_Ref_count_obj<AdblockPlus::JsEngine>::_Ref_count_obj<AdblockPlus::JsEngine><AdblockPlus::JsEngine::PrivateCtrArg>(AdblockPlus::JsEngine::PrivateCtrArg && <_Args_0>) Line 932	C++
 	tests.exe!std::make_shared<AdblockPlus::JsEngine,AdblockPlus::JsEngine::PrivateCtrArg>(AdblockPlus::JsEngine::PrivateCtrArg && <_Args_0>) Line 1003	C++
 	tests.exe!AdblockPlus::JsEngine::New(const AdblockPlus::AppInfo & appInfo) Line 80	C++
....

Change History (3)

comment:1 Changed 5 years ago by sergz

  • Description modified (diff)
  • Summary changed from Create v8::Platform and initialize v8::V8 to Initialize v8::V8

comment:2 Changed 5 years ago by sergz

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 5 years ago by sergz

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.