Opened 5 years ago

Closed 5 years ago

#1551 closed change (fixed)

Move global callbackParams and stuff around it into the scope of particular test

Reported by: sergz Assignee:
Priority: Unknown Milestone:
Module: Libadblockplus Keywords:
Cc: Blocked By:
Blocking: #1197 Platform: Unknown
Ready: no Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5139568831496192/

Description

Background

The file is test/JsEngine.cpp.
In the recent v8 the order of destroying of isolate is very important. Global callbackParams holds the pointer to isolate and accesses it in the destructor. At this moment the isolate is already destroyed and the application crashes.

Change History (2)

comment:1 Changed 5 years ago by sergz

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 5 years ago by sergz

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.