Opened 5 years ago

Closed 5 years ago

#1552 closed change (fixed)

Add v8::Isolate::Scope member into JsContext

Reported by: sergz Assignee:
Priority: Unknown Milestone:
Module: Libadblockplus Keywords:
Cc: Blocked By:
Blocking: #1197 Platform: Unknown
Ready: no Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6734437559566336/

Description (last modified by sergz)

Background

It sets current isolate and v8 stuff into thread local storage. Since we use it from different threads, it's required for the proper work

Without v8::Isolate::Scope current isolate is nullptr.

Callstack of crash

>	tests.exe!v8::internal::Isolate::Current() Line 489	C++
 	tests.exe!v8::TryCatch::TryCatch() Line 1912	C++
 	tests.exe!AdblockPlus::JsValue::Call(const std::vector<std::shared_ptr<AdblockPlus::JsValue>,std::allocator<std::shared_ptr<AdblockPlus::JsValue> > > & params, std::shared_ptr<AdblockPlus::JsValue> thisPtr) Line 226	C++
 	tests.exe!`anonymous namespace'::ReadThread::Run() Line 81	C++
 	tests.exe!`anonymous namespace'::CallRun(AdblockPlus::Thread * thread) Line 31	C++
 	kernel32.dll!@BaseThreadInitThunk@12()	Unknown
 	ntdll.dll!__RtlUserThreadStart()	Unknown
 	ntdll.dll!__RtlUserThreadStart@8()	Unknown

Change History (3)

comment:1 Changed 5 years ago by sergz

  • Blocking 1197 added
  • Cc 1197 removed
  • Description modified (diff)

comment:2 Changed 5 years ago by sergz

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 5 years ago by sergz

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.