Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#156 closed defect (fixed)

wrong icons parameter value in manifest.json for chrome

Reported by: saroyanm Assignee: saroyanm
Priority: P4 Milestone: Adblock-Plus-1.8-for-Chrome-Opera-Safari
Module: Platform Keywords: chrome, manifest, buildtools
Cc: Blocked By:
Blocking: Platform:
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5406295150559232/
http://codereview.adblockplus.org/5676337998069760

Description

How to reproduce

  1. build adblockpluschrome project using "./build.py -t chrome build"

...

Observed behaviour

icons parameter in manifest.json contains current object:
"icons": {

"128": "icons/abp-128.png",
"32": "icons/abp-32.png"

},

Expected behaviour

icons parameter in manifest.json should contain current object:
"icons": {

"128": "icons/abp-128.png",
"48": "icons/abp-48.png",
"16": "icons/abp-16.png"

},
according to chrome manifest documentation:
http://developer.chrome.com/extensions/manifest/icons

Change History (5)

comment:1 Changed 6 years ago by saroyanm

  • Status changed from new to assigned

comment:2 Changed 6 years ago by saroyanm

  • in_progress set to 0
  • Ready unset

While the icons were moved to their appropriate directories in current review:
http://codereview.adblockplus.org/5406295150559232

icons/abp-48.png and icons/abp-16.png are no more available in icons directory.

comment:3 Changed 6 years ago by trev

  • in_progress changed from 0 to 1
  • Ready set
  • Review URL(s) modified (diff)
  • Status changed from assigned to reviewing

comment:4 Changed 6 years ago by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 6 years ago by trev

  • Component changed from Build-and-Release-Tools to Platform
  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
Note: See TracTickets for help on using tickets.