Opened 5 years ago

Closed 5 years ago

#1561 closed change (fixed)

Move unit tests out of the browser's content area

Reported by: trev Assignee: trev
Priority: P3 Milestone:
Module: Extensions-for-Adblock-Plus Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5745141503492096/

Description

Background

Unit tests are currently running inside the browser's content area. This has the advantage of requiring no UI - entering a URL into the browser's location bar is enough. However, it also makes some things harder because the unit tests run on the wrong side of the security boundary. And the unit tests are completely broken with e10s because they run in the content process and not the chrome process now.

What to change

Create a XUL window for the unit tests so that no longer are in the browser's content are. Provide some minimal UI in the inline preferences to open that window.

Change History (4)

comment:1 Changed 5 years ago by trev

With my current changes most tests continue to work correctly. The pop-up blocking tests fail, that's pretty much expected as these expect to find a browser window. The unexpected part is content policy and element hiding tests failing, these simply don't get the load event for the frame for some reason (both with e10s and without).

comment:2 Changed 5 years ago by trev

  • Review URL(s) modified (diff)

Created review for work in progress, AFAICT only pop-up blocker tests still need to be fixed.

comment:3 Changed 5 years ago by trev

  • Status changed from new to reviewing

Review has been finalized.

comment:4 Changed 5 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.