Opened on 11/18/2014 at 03:48:45 PM

Closed on 11/19/2014 at 01:36:22 PM

Last modified on 11/19/2014 at 01:36:51 PM

#1583 closed change (rejected)

Implement validation of CSS selectors in element hiding filters

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone:
Module: Core Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: no Confidential: no
Tester: Verified working: no
Review URL(s):

Description (last modified by sebastian)


With #491 and #493 we are going to validate custom filters. Filter.fromText() already does some basic validation, returning an InvalidFilter filter object in some cases. However, it currently doesn't protect against invalid CSS used in element hiding filters.

What to change

Add an optional strict argument to Filter.fromText() and ElemHideBase.fromText(). When this argument is present and true, an InvalidFilter must be returned if it's an element hiding filter using an invalid CSS selector.

Attachments (0)

Change History (5)

comment:1 Changed on 11/18/2014 at 03:49:05 PM by sebastian

  • Blocking 491 removed

comment:2 Changed on 11/18/2014 at 03:49:20 PM by sebastian

  • Blocked By 491 added

comment:3 Changed on 11/18/2014 at 03:55:19 PM by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 11/18/2014 at 04:05:14 PM by sebastian

  • Description modified (diff)

comment:5 Changed on 11/19/2014 at 01:36:22 PM by sebastian

  • Blocked By 491 removed
  • Blocking 493 removed
  • Ready unset
  • Resolution set to rejected
  • Review URL(s) modified (diff)
  • Status changed from reviewing to closed

Apparently there is no document object where the core code runs on most platforms. Therefore the code validating CSS selectors will be platform specific. So trev and I agreed to not implement it in the core.

Last edited on 11/19/2014 at 01:36:51 PM by sebastian

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sebastian.
Note: See TracTickets for help on using tickets.